I think you have done an excellent job Trevor.
We are having a big debate behind the scenes of the blog at the moment on what to call these clues. Some say they are &lit (and literally so) and others prefer all-in-one. We are leaning towards the latter at the moment as being more descriptive.
Basically, if the wordplay uses up all the words in the clue, and then you have to read the clue again to get the definition, then it is this type of clue. The "?" is optional in the UK, although preferred in the US. I am preparing a guide to add to the blog, but it's a harder task than I first thought.
You can read more here: http://en.wikipedia.org/wiki/Cryptic_crosswords
but no single source is definitive. An excellent example came up today on this forum: http://www.crosswordsolver.org/forum/7862/st4321
@Rob - you will probably get more help on this forum from people who don't do this puzzle than from people who do, which is why we ask you to give the clues. Placed letters also help in case your answer is, perish the thought, incorrect.